From 961be70139c04beb19d4b514afa73eadee54d23c Mon Sep 17 00:00:00 2001 From: Athos Ribeiro Date: Thu, 9 Jan 2025 11:37:14 -0300 Subject: [PATCH] Low: controller: address format-overflow warnings When using -O3 to build pacemaker, gcc (14) will throw format-overflow warnings for some possibly null '%s' directive arguments. While we could address the current instance of such warning by introducing checks for null pointers, let's just remove this log entry here since it is not meaningful. alerts.c:153:19: error: '%s' directive argument is null [-Werror=format-overflow=] 153 | crm_trace("Inserting alert key %s = '%s'", *key, value); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ alerts.c:153:46: note: format string is defined here 153 | crm_trace("Inserting alert key %s = '%s'", *key, value); | Signed-off-by: Athos Ribeiro --- daemons/controld/controld_te_events.c | 1 - 1 file changed, 1 deletion(-) diff --git a/daemons/controld/controld_te_events.c b/daemons/controld/controld_te_events.c index 9ac0a2c4a2..b65f43ab10 100644 --- a/daemons/controld/controld_te_events.c +++ b/daemons/controld/controld_te_events.c @@ -327,7 +327,6 @@ get_cancel_action(const char *id, const char *node) task = crm_element_value(action->xml, PCMK__XA_OPERATION_KEY); if (!pcmk__str_eq(task, id, pcmk__str_casei)) { - crm_trace("Wrong key %s for %s on %s", task, id, node); continue; } -- 2.43.0