From 6346c2a25dbd73bf2e8fe4f8520c50ce01d74327 Mon Sep 17 00:00:00 2001
From: Jonathan Kang <jonathankang@gnome.org>
Date: Thu, 17 Sep 2026 07:53:05 +0800
Subject: [PATCH] dnf5: Never execute repo-remove for simulated transactions

An unprivileged local user could call RepoRemove with the SIMULATE
(dry-run) flag and still trigger a real root package uninstall with no
polkit prompt.

Return after emitting the resolved package list whenever SIMULATE or
ONLY_DOWNLOAD is set, so the download-and-run path only executes for a
properly authorized transaction.

Resolves: CVE-2026-19816, GHSA-g5gf-h68q-gxc8
---
 backends/dnf5/dnf5-backend-thread.cpp | 77 +++++++++++++++++++--------
 1 file changed, 54 insertions(+), 23 deletions(-)

diff --git a/backends/dnf5/dnf5-backend-thread.cpp b/backends/dnf5/dnf5-backend-thread.cpp
index 0f7679264..c6ff1ecc8 100644
--- a/backends/dnf5/dnf5-backend-thread.cpp
+++ b/backends/dnf5/dnf5-backend-thread.cpp
@@ -391,13 +391,19 @@ dnf5_transaction_thread (PkBackendJob *job, GVariant *params, gpointer user_data
 
 		libdnf5::Goal goal(*priv->base);
 		PkBitfield transaction_flags = 0;
+		// track whether we mutated the shared base config and thus must rebuild the base,
+		// so the change does not leak into later transactions.
+		bool base_config_dirty = false;
 		
 		if (role == PK_ROLE_ENUM_INSTALL_PACKAGES || role == PK_ROLE_ENUM_UPDATE_PACKAGES || role == PK_ROLE_ENUM_REMOVE_PACKAGES) {
 			g_auto(GStrv) package_ids = NULL;
 			if (role == PK_ROLE_ENUM_REMOVE_PACKAGES) {
 				gboolean allow_deps, autoremove;
 				g_variant_get (params, "(t^asbb)", &transaction_flags, &package_ids, &allow_deps, &autoremove);
-				if (autoremove) priv->base->get_config().get_clean_requirements_on_remove_option().set(true);
+				if (autoremove) {
+					priv->base->get_config().get_clean_requirements_on_remove_option().set(true);
+					base_config_dirty = true;
+				}
 			} else {
 				g_variant_get (params, "(t^as)", &transaction_flags, &package_ids);
 			}
@@ -405,6 +411,8 @@ dnf5_transaction_thread (PkBackendJob *job, GVariant *params, gpointer user_data
 			auto pkgs = dnf5_resolve_package_ids(*priv->base, package_ids);
 			if (pkgs.empty() && role != PK_ROLE_ENUM_UPDATE_PACKAGES) {
 				pk_backend_job_error_code (job, PK_ERROR_ENUM_PACKAGE_NOT_FOUND, "No packages found");
+				if (base_config_dirty)
+					dnf5_setup_base(priv);
 				pk_backend_job_finished (job);
 				return;
 			}
@@ -473,6 +481,8 @@ dnf5_transaction_thread (PkBackendJob *job, GVariant *params, gpointer user_data
 			std::string msg;
 			for (const auto &p : problems) msg += p + "; ";
 			pk_backend_job_error_code (job, PK_ERROR_ENUM_DEP_RESOLUTION_FAILED, "%s", msg.c_str());
+			if (base_config_dirty)
+				dnf5_setup_base(priv);
 			pk_backend_job_finished (job);
 			return;
 		}
@@ -510,6 +520,10 @@ dnf5_transaction_thread (PkBackendJob *job, GVariant *params, gpointer user_data
 				if (info != PK_INFO_ENUM_UNKNOWN)
 					dnf5_emit_pkg(job, item.get_package(), info);
 			}
+			// a simulation must not modify the system: reset the base so the
+			// temporary config does not leak into later transactions
+			if (base_config_dirty)
+				dnf5_setup_base(priv);
 			pk_backend_job_finished (job);
 			return;
 		}
@@ -544,6 +558,8 @@ dnf5_transaction_thread (PkBackendJob *job, GVariant *params, gpointer user_data
 				if (info != PK_INFO_ENUM_UNKNOWN)
 					dnf5_emit_pkg(job, item.get_package(), info);
 			}
+			if (base_config_dirty)
+				dnf5_setup_base(priv);
 			pk_backend_job_finished (job);
 			return;
 		}
@@ -702,30 +718,45 @@ dnf5_repo_thread (PkBackendJob *job, GVariant *params, gpointer user_data)
 				return;
 			}
 			
-			if (role == PK_ROLE_ENUM_REPO_REMOVE || !pk_bitfield_contain (transaction_flags, PK_TRANSACTION_FLAG_ENUM_SIMULATE)) {
-				pk_backend_job_set_status (job, PK_STATUS_ENUM_DOWNLOAD);
-				g_debug("Starting transaction download...");
-				trans.download();
-				pk_backend_job_set_status (job, PK_STATUS_ENUM_RUNNING);
-				g_debug("Starting transaction execution...");
-				trans.set_description("PackageKit: repo-remove " + std::string(repo_id));
-				auto res = trans.run();
-				g_debug("Transaction run result: %s", libdnf5::base::Transaction::transaction_result_to_string(res).c_str());
-				if (res != libdnf5::base::Transaction::TransactionRunResult::SUCCESS) {
-					std::vector<std::string> problems = trans.get_transaction_problems();
-					std::string msg;
-					for (const auto &p : problems) msg += p + "; ";
-					g_warning("Transaction failed: %s", msg.c_str());
-					pk_backend_job_error_code (job, PK_ERROR_ENUM_TRANSACTION_ERROR, "Transaction failed: %s", msg.c_str());
-				} else {
-					g_debug("Transaction completed successfully");
-					// Update timestamp to inhibit notifications from our own transaction
-					priv->last_notification_timestamp = g_get_monotonic_time ();
-				}
-				dnf5_setup_base (priv);
-			} else {
+			// The daemon does not require authorization for SIMULATE (and ONLY_DOWNLOAD)
+			// transactions, so we must never modify the system in that case
+			if (pk_bitfield_contain(transaction_flags, PK_TRANSACTION_FLAG_ENUM_SIMULATE)
+			    || pk_bitfield_contain(transaction_flags, PK_TRANSACTION_FLAG_ENUM_ONLY_DOWNLOAD)) {
 				g_debug("Simulation completed, finishing job...");
+				// reset the base so the temporary autoremove config does not leak into
+				// subsequent transactions
+				if (autoremove)
+					dnf5_setup_base(priv);
+				pk_backend_job_finished(job);
+				return;
+			}
+
+			pk_backend_job_set_status(job, PK_STATUS_ENUM_DOWNLOAD);
+			g_debug("Starting transaction download...");
+			trans.download();
+			pk_backend_job_set_status(job, PK_STATUS_ENUM_RUNNING);
+			g_debug("Starting transaction execution...");
+			trans.set_description("PackageKit: repo-remove " + std::string(repo_id));
+			auto res = trans.run();
+			g_debug("Transaction run result: %s",
+				libdnf5::base::Transaction::transaction_result_to_string(res).c_str());
+			if (res != libdnf5::base::Transaction::TransactionRunResult::SUCCESS) {
+				std::vector<std::string> problems = trans.get_transaction_problems();
+				std::string msg;
+				for (const auto &p : problems)
+					msg += p + "; ";
+				g_warning("Transaction failed: %s", msg.c_str());
+				pk_backend_job_error_code(
+					job,
+					PK_ERROR_ENUM_TRANSACTION_ERROR,
+					"Transaction failed: %s",
+					msg.c_str());
+			} else {
+				g_debug("Transaction completed successfully");
+				// Update timestamp to inhibit notifications from our own transaction
+				priv->last_notification_timestamp = g_get_monotonic_time();
 			}
+			dnf5_setup_base(priv);
 		}
 	} catch (const std::exception &e) {
 		g_warning("Exception in dnf5_repo_thread: %s", e.what());
-- 
2.55.0

