From: Prasanna Kumar Kalever Date: Sun, 21 May 2017 15:14:05 +0530 Subject: glfs: discard glfs_check_config Git-commit: 61bd03e600d2abf309173e9186f4d465bb1b7157 References: bsc#1049485 Signed-off-by: Prasanna Kumar Kalever Acked-by: Lee Duncan --- glfs.c | 54 ------------------------------------------------------ 1 file changed, 54 deletions(-) --- a/glfs.c +++ b/glfs.c @@ -403,58 +403,6 @@ static char* tcmu_get_path( struct tcmu_ return config; } - -static bool glfs_check_config(const char *cfgstring, char **reason) -{ - char *path; - glfs_t *fs = NULL; - glfs_fd_t *gfd = NULL; - gluster_server *hosts; /* gluster server defination */ - bool result = true; - - path = strchr(cfgstring, '/'); - if (!path) { - if (asprintf(reason, "No path found") == -1) - *reason = NULL; - result = false; - goto done; - } - path += 1; /* get past '/' */ - - fs = tcmu_create_glfs_object(path, &hosts); - if (!fs) { - tcmu_err("tcmu_create_glfs_object failed\n"); - goto done; - } - - gfd = glfs_open(fs, hosts->path, ALLOWED_BSOFLAGS); - if (!gfd) { - if (asprintf(reason, "glfs_open failed: %m") == -1) - *reason = NULL; - result = false; - goto unref; - } - - if (glfs_access(fs, hosts->path, R_OK|W_OK) == -1) { - if (asprintf(reason, "glfs_access file not present, or not writable") == -1) - *reason = NULL; - result = false; - goto unref; - } - - goto done; - -unref: - gluster_cache_refresh(fs, path); - -done: - if (gfd) - glfs_close(gfd); - gluster_free_server(hosts); - - return result; -} - static int tcmu_glfs_open(struct tcmu_device *dev) { struct glfs_state *gfsp; @@ -575,8 +523,6 @@ struct tcmur_handler glfs_handler = { .subtype = "glfs", .cfg_desc = glfs_cfg_desc, - .check_config = glfs_check_config, - .open = tcmu_glfs_open, .close = tcmu_glfs_close, .read = tcmu_glfs_read,