From 994c1553a158ada9db5ab64c9178a0d23c0a42ce Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Wed, 29 Mar 2023 13:07:03 +0100 Subject: x86: Remove temporary {cpuid,msr}_policy defines With all code areas updated, drop the temporary defines and adjust all remaining users. No practical change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -15,7 +15,7 @@ * separate CPUID features for this functionality, but only set will be * active. */ -uint64_t msr_spec_ctrl_valid_bits(const struct cpuid_policy *cp) +uint64_t msr_spec_ctrl_valid_bits(const struct cpu_policy *cp) { bool ssbd = cp->feat.ssbd || cp->extd.amd_ssbd; bool psfd = cp->feat.intel_psfd || cp->extd.psfd; @@ -65,7 +65,7 @@ void guest_cpuid(const struct vcpu *v, u uint32_t subleaf, struct cpuid_leaf *res) { const struct domain *d = v->domain; - const struct cpuid_policy *p = d->arch.cpuid; + const struct cpu_policy *p = d->arch.cpu_policy; *res = EMPTY_LEAF; --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -396,7 +396,7 @@ static void release_compat_l4(struct vcp unsigned long pv_fixup_guest_cr4(const struct vcpu *v, unsigned long cr4) { - const struct cpuid_policy *p = v->domain->arch.cpuid; + const struct cpu_policy *p = v->domain->arch.cpu_policy; /* Discard attempts to set guest controllable bits outside of the policy. */ cr4 &= ~((p->basic.tsc ? 0 : X86_CR4_TSD) | --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -50,7 +50,7 @@ static int gdbsx_guest_mem_io(domid_t do static int update_domain_cpuid_info(struct domain *d, const xen_domctl_cpuid_t *ctl) { - struct cpuid_policy *p = d->arch.cpuid; + struct cpu_policy *p = d->arch.cpu_policy; const struct cpuid_leaf leaf = { ctl->eax, ctl->ebx, ctl->ecx, ctl->edx }; int old_vendor = p->x86_vendor; unsigned int old_7d0 = p->feat.raw[0].d, old_e8b = p->extd.raw[8].b; --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -883,7 +883,7 @@ const char *hvm_efer_valid(const struct signed int cr0_pg) { const struct domain *d = v->domain; - const struct cpuid_policy *p = d->arch.cpuid; + const struct cpu_policy *p = d->arch.cpu_policy; if ( value & ~EFER_KNOWN_MASK ) return "Unknown bits set"; @@ -924,7 +924,7 @@ const char *hvm_efer_valid(const struct unsigned long hvm_cr4_guest_valid_bits(const struct vcpu *v, bool restore) { const struct domain *d = v->domain; - const struct cpuid_policy *p = d->arch.cpuid; + const struct cpu_policy *p = d->arch.cpu_policy; bool mce, vmxe; /* Logic broken out simply to aid readability below. */ --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -640,7 +640,7 @@ static void svm_cpuid_policy_changed(str { struct arch_svm_struct *arch_svm = &v->arch.hvm_svm; struct vmcb_struct *vmcb = arch_svm->vmcb; - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; u32 bitmap = vmcb_get_exception_intercepts(vmcb); if ( opt_hvm_fep || --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -661,7 +661,7 @@ void vmx_update_exception_bitmap(struct static void vmx_cpuid_policy_changed(struct vcpu *v) { - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; if ( opt_hvm_fep || (v->domain->arch.cpuid->x86_vendor != boot_cpu_data.x86_vendor) ) @@ -3246,7 +3246,7 @@ void vmx_vlapic_msr_changed(struct vcpu static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content) { struct vcpu *v = current; - const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct cpu_policy *cp = v->domain->arch.cpu_policy; HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x, msr_value=%#"PRIx64, msr, msr_content); --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -918,7 +918,7 @@ void cpuid_hypervisor_leaves(const struc uint32_t subleaf, struct cpuid_leaf *res) { const struct domain *d = v->domain; - const struct cpuid_policy *p = d->arch.cpuid; + const struct cpu_policy *p = d->arch.cpu_policy; uint32_t base = is_viridian_domain(d) ? 0x40000100 : 0x40000000; uint32_t idx = leaf - base; unsigned int limit = is_viridian_domain(d) ? p->hv2_limit : p->hv_limit; --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -673,7 +673,7 @@ static bool_t valid_xcr0(u64 xcr0) int validate_xstate(const struct domain *d, uint64_t xcr0, uint64_t xcr0_accum, const struct xsave_hdr *hdr) { - const struct cpuid_policy *cp = d->arch.cpuid; + const struct cpu_policy *cp = d->arch.cpuid; uint64_t xcr0_max = ((uint64_t)cp->xstate.xcr0_high << 32) | cp->xstate.xcr0_low; unsigned int i; @@ -699,7 +699,7 @@ int validate_xstate(const struct domain int handle_xsetbv(u32 index, u64 new_bv) { struct vcpu *curr = current; - const struct cpuid_policy *cp = curr->domain->arch.cpuid; + const struct cpu_policy *cp = curr->domain->arch.cpuid; uint64_t xcr0_max = ((uint64_t)cp->xstate.xcr0_high << 32) | cp->xstate.xcr0_low; u64 mask; --- a/xen/include/asm-x86/cpu-policy.h +++ b/xen/include/asm-x86/cpu-policy.h @@ -314,10 +314,6 @@ extern struct cpu_policy host_cpu_pol extern struct cpu_policy pv_max_cpu_policy; extern struct cpu_policy hvm_max_cpu_policy; -/* Temporary */ -#define cpuid_policy cpu_policy -#define msr_policy cpu_policy - /** * Copy the featureset words out of a cpu_policy object. */ --- a/xen/include/asm-x86/msr.h +++ b/xen/include/asm-x86/msr.h @@ -224,7 +224,7 @@ static inline void wrmsr_tsc_aux(uint32_ } } -uint64_t msr_spec_ctrl_valid_bits(const struct cpuid_policy *cp); +uint64_t msr_spec_ctrl_valid_bits(const struct cpu_policy *cp); #endif /* !__ASSEMBLY__ */